Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Overhaul using BEM naming convention #39

Closed
wants to merge 36 commits into from
Closed

Visual Overhaul using BEM naming convention #39

wants to merge 36 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 22, 2019

Visual Overhaul using BEM naming convention.

Why BEM (Block, Element, Modifier)? The name of a BEM entity is unique. The same BEM entity always has the same name in all technologies (CSS, JavaScript, and HTML). The primary purpose of the naming convention is to give names meaning so that they are as informative as possible for the developer. Learn more

  • Redesign some components.
  • index.php new classes
    • "main-filesource"
    • "main-footer"
    • "main-footer__warning"
    • "main-footer__extension"
  • info_v3.js reword "Synopses" to "Synopsis"
  • index_v3.js change width 640 to 642

Emmanuel See Te added 3 commits March 22, 2019 11:51
- info_v3.js reword "Synopses" to "Synopsis"
- index_v3.js change width 640 to 642
new classes :
    + "main-filesource"
    + "main-footer"
    + "main-footer__warning"
    + "main-footer__extension"
@soruly
Copy link
Owner

soruly commented Mar 22, 2019

Why change width from 640px to 642px?

@ghost
Copy link
Author

ghost commented Mar 22, 2019

I thought there will be some conflict on display "aesthetic". Well I don't see any problem, it can stay at 640 I guess.

image

Emmanuel See Te added 9 commits March 22, 2019 12:11
Visual Overhaul for About, Changelog, FAQ's, Terms
Will do RWD next.

Add more classes.
Visual Overhaul for About, Changelog, FAQ's, Terms
Will do RWD next.

Add more classes.
Visual Overhaul for About, Changelog, FAQ's, Terms
Will do RWD next.

Reconstruct html structure
Add more classes.
Visual Overhaul for About, Changelog, FAQ's, Terms
Will do RWD next.

Reconstruct html structure
Add more classes.
Visual Overhaul for About, Changelog, FAQ's, Terms
Will do RWD next.

Reconstruct html structure
Add more classes.
Visual Overhaul for About, Changelog, FAQ's, Terms
Will do RWD next.

Reconstruct html structure
Add more classes.
Visual Overhaul for About, Changelog, FAQ's, Terms
Will do RWD next.

Reconstruct html structure
Add more classes.
@ghost
Copy link
Author

ghost commented Mar 22, 2019

Visual Overhaul

Home:
image

About:
image
image

Changelog:
image

FAQs:
image
image
image

Terms:
image

@ghost ghost changed the title Redesign some components (Visual Overhaul) Redesign some components Mar 22, 2019
index.php Outdated Show resolved Hide resolved
css/index.css Outdated Show resolved Hide resolved
css/index.css Outdated Show resolved Hide resolved
Emmanuel See Te added 2 commits March 23, 2019 11:39
- New css variables for fonts, box-shadow, default-color, transition
- Changed theme color
- #preview width removed (default to 640)
- box-shadow rewrite
- Clean up css
- New theme color (#60738b)
- #preview width from 642 to 640
- Fix classes
- Modify notes
- Changelog: The latest post will have a colored background on date holder
- Additional: Navigation bar responsive on the way, you can already see the effect by adjusting the width using Responsive Design Mode or zooming in. Still working on this one.
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots in FAQ's are already responsive

@ghost
Copy link
Author

ghost commented Mar 23, 2019

Some screenshot on new color. Will be working next on dark mode switcher.

image
image
image

Emmanuel See Te added 3 commits March 23, 2019 16:53
+ navigation change (new mobile friendly)
+ index; octocat style moved to style.css
+ navigation change (new mobile friendly)
+ octocat style has been moved here
+ some style fixes
@ghost
Copy link
Author

ghost commented Mar 23, 2019

New mobile navigation v1

Mobile Navigation

Emmanuel See Te added 3 commits March 24, 2019 15:02
This new stylesheet is using BEM naming convention.
- Lots of style changes.
- With different theme color for Home, About, Changelog, FAQ, Terms
Convert all class to BEM as much as possible for organized layout
@ghost
Copy link
Author

ghost commented Mar 24, 2019

Update: Now using BEM naming convention

The new design:
https://i.gyazo.com/358ee3192a267f39de3a72a20356bb3c.gif
trace moe overview design

Per page:
1_home
2_about
3_changelog
4_faq
5_terms

@ghost ghost changed the title (Visual Overhaul) Redesign some components Visual Overhaul using BEM naming convention Mar 24, 2019
@soruly
Copy link
Owner

soruly commented Mar 24, 2019

Have you tried the search results layout? with anilist panel and thumbnail images previews

@soruly
Copy link
Owner

soruly commented Mar 24, 2019

Update: Now using BEM naming convention

The new design:
https://i.gyazo.com/358ee3192a267f39de3a72a20356bb3c.gif
trace moe overview design

Per page:
1_home
2_about
3_changelog
4_faq
5_terms

Preferably I'd like to use the same color theme for all pages, like youtube is red in all pages, facebook is blue for all its pages.

@soruly
Copy link
Owner

soruly commented Mar 24, 2019

It seems your css\app.css uses CSS variables which Internet Explorer 11 does not support
Can you test your layout on IE?

@ghost
Copy link
Author

ghost commented Mar 24, 2019

It seems your css\app.css uses CSS variables which Internet Explorer 11 does not support
Can you test your layout on IE?

Working on fallback version now.

Edit: It should work fine now.

IE does not support variables.

Fallback values (Browser that doesn't support css variables):
- Primary color: #3f51b5
- Primary light color: #7986cb
- Primary dark color: #303f9f
- Border radius: 2px
- Transition: 135ms cubic-bezier(.4,0,.2,1)
- Font: "Roboto", Helvetica, Arial, "Meiryo", "Microsoft JhengHei", "Microsoft YaHei", sans-serif
- Shadow: 0 1px 1px 0 rgba(60,64,67,.08),0 1px 3px 1px rgba(60,64,67,.16)
- Shadow hover: 0 1px 3px 1px rgba(60,64,67,.2),0 2px 8px 4px rgba(60,64,67,.1)
@ghost
Copy link
Author

ghost commented Mar 24, 2019

Have you tried the search results layout? with anilist panel and thumbnail images previews

I can but it will take some time since all elements are in info_v3.js

PS: No thumbnail I just copy the source from trace.moe (Its the same after all)
image
image
image

@soruly
Copy link
Owner

soruly commented Mar 24, 2019

Have you tried the search results layout? with anilist panel and thumbnail images previews

I can but it will take some time since all elements are in info_v3.js

PS: No thumbnail I just copy the source from trace.moe (Its the same after all)
image
image
image

It seems to me the top nav bar is too thick, taking too many vertical space. And the recent updates notification bar... seems occupying too much space too. But I'm not sure if there're better place to put it. Do you have better ideas?

@ghost
Copy link
Author

ghost commented Mar 24, 2019

Have you tried the search results layout? with anilist panel and thumbnail images previews

I can but it will take some time since all elements are in info_v3.js
PS: No thumbnail I just copy the source from trace.moe (Its the same after all)
image
image
image

It seems to me the top nav bar is too thick, taking too many vertical space. And the recent updates notification bar... seems occupying too much space too. But I'm not sure if there're better place to put it. Do you have better ideas?

working on it

@ghost
Copy link
Author

ghost commented Mar 24, 2019

Well I just adjust the thickness after all.
image

Emmanuel See Te added 7 commits March 24, 2019 21:27
Add some important updates and notes

- Speeding up search on whatanime.ga!
- Moving to new domain: trace.moe
- Recent updates to trace.moe

Source: Patreon
+ Separate fallback style to app_fallback.css
	- For easy editing and adjustments
+ Clean up classes
	- Adjust classes
	- Removed unnecessary classes

Note: Will be working next on index (main, info, results, etc...).
+ 1 theme color for all pages
	- Indigo (#3f51b5)
+ Clean up code
	- For better editing and adjustments

Note: Will be working next on index (main, info, results, etc...).
@ghost
Copy link
Author

ghost commented Mar 25, 2019

Style update for search, results list, info.

Search: Search
image

@ghost
Copy link
Author

ghost commented Mar 27, 2019

Update stylesheet to LESS (Includes non minified and minified version of CSS).
Update classes, design, texts, indentions, divs
Add terms in sitemap.txt
Change css links to app.min.css

image

@ghost
Copy link
Author

ghost commented Mar 28, 2019

Ready to merge anytime. If there's any problem or bug you can contact me anytime. Thank you.

Closing pull request.

@ghost ghost closed this Mar 28, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant