Fix exceptions in rump connections. #47
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Wild West that is the public Internet, you sometimes get a connection
that executes all or a part of the TLS handshake and then does nothing or
drops the connection. sstp-server starts a Hello timer as soon as a
connection is established, and it will expire some time after the client
drops the connection. Since the SSTPProtocol object doesn't have the
transport attribute when the Hello timer expires, an exception is generated.
BTW, a review of code should be performed since it's possible there's a
memory leak in these or other pathologic situations.