Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions in rump connections. #47

Closed
wants to merge 1 commit into from
Closed

Fix exceptions in rump connections. #47

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 16, 2022

In the Wild West that is the public Internet, you sometimes get a connection
that executes all or a part of the TLS handshake and then does nothing or
drops the connection. sstp-server starts a Hello timer as soon as a
connection is established, and it will expire some time after the client
drops the connection. Since the SSTPProtocol object doesn't have the
transport attribute when the Hello timer expires, an exception is generated.

BTW, a review of code should be performed since it's possible there's a
memory leak in these or other pathologic situations.

In the Wild West that is the public Internet, you sometimes get a connection
that executes all or a part of the TLS handshake and then does nothing or
drops the connection. sstp-server starts a Hello timer as soon as a
connection is established, and it will expire some time after the client
drops the connection. Since the SSTPProtocol object doesn't have the
transport attribute when the Hello timer expires, an exception is generated.

BTW, a review of code should be performed since it's possible there's a
memory leak in these or other pathologic situations.
@ghost ghost closed this by deleting the head repository Nov 9, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants