Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intruder_alarm stability #12

Open
hawkw opened this issue Jan 20, 2018 · 3 comments
Open

intruder_alarm stability #12

hawkw opened this issue Jan 20, 2018 · 3 comments
Assignees

Comments

@hawkw
Copy link
Member

hawkw commented Jan 20, 2018

Right now, core::ptr::NonNull (née ptr::Shared) is the main unstable feature blocking intruder_alarm from building with the stable compiler. As of rust-lang/rust#46952, it's coming to stable Real Soon Now (under its' new name).

The other gated feature that intruder_alarm uses is const_fn, which is pretty easy to hack around (e.g. with a macro) or just with conditional compilation. In light of that, intruder_alarm may soon compile on stable Rust.

Let's try to avoid adding any new feature gates, so that when ptr::NonNull makes it to stable, intruder_alarm will build against stable.

@hawkw hawkw self-assigned this Jan 20, 2018
@hawkw hawkw added this to To Do in Intruder Alarm via automation Jan 20, 2018
@hawkw hawkw moved this from To Do to In progress in Intruder Alarm Jan 20, 2018
@hawkw hawkw moved this from In progress to Blocked in Intruder Alarm Feb 1, 2018
@leshow
Copy link
Collaborator

leshow commented Feb 1, 2018

Isn't the custom allocator stuff for nightly only also?

@hawkw
Copy link
Member Author

hawkw commented Feb 2, 2018

@leshow

Isn't the custom allocator stuff for nightly only also?

Yeah, that's correct. But if nothing is keeping the intrusive collections crate --- separate from the actual allocator implementations --- from building on stable, why not? I'm sure there are some other use-cases for intrusive collections other than writing allocators...

@hawkw
Copy link
Member Author

hawkw commented Feb 2, 2018

(which is my way of saying, "i'd like to ship intruder_alarm to crates.io independently of the allocators)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Intruder Alarm
  
Blocked
Development

No branches or pull requests

2 participants