Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite Question Tag Highlighting with Wildcards* #48

Closed
mezmi opened this issue Apr 10, 2016 · 8 comments
Closed

Favorite Question Tag Highlighting with Wildcards* #48

mezmi opened this issue Apr 10, 2016 · 8 comments
Assignees
Labels
Milestone

Comments

@mezmi
Copy link
Contributor

mezmi commented Apr 10, 2016

Installed Version: 1.0.4DEV | Environment: Tampermonkey/Chrome

The favorite question tag highlighting should work with tag wildcards *.

Right now, it's missing a lot.

tag-skipping

@mezmi mezmi added the bug label Apr 10, 2016
@mezmi mezmi added this to the v1.0.4 milestone Apr 10, 2016
@shu8
Copy link
Member

shu8 commented Apr 10, 2016

@enki-code I see this:

screen shot 2016-04-10 at 10 36 44

When I have the asp.net-mvc* tag favourited... are you sure you have the latest DEV installed?

If you do, any errors in console? Because it seems to be working for asp.net-mvc, which means the regex is being converted properly...

I don't know why it should skip some tags.. so hopefully there's an error I can work from! :P

@shu8
Copy link
Member

shu8 commented Apr 15, 2016

@enki-code does this still happen? Anything in the console?

@mezmi
Copy link
Contributor Author

mezmi commented Apr 15, 2016

@shu8
Yeah, it's still happening, no errors in the console.. I will reinstall and check later, I'm in a rush to get out of the house today. Sorry.

@shu8
Copy link
Member

shu8 commented Apr 15, 2016

@enki-code sure no problem :)

@mezmi
Copy link
Contributor Author

mezmi commented Apr 17, 2016

No errors in the console.

It's still skipping some tags though.

tag-wildcards

tag-wildcards2

@shu8
Copy link
Member

shu8 commented Apr 17, 2016

@enki-code hmm.. ok thanks. I'll look into it a bit deeper ;|

shu8 added a commit that referenced this issue Apr 30, 2016
shu8 added a commit that referenced this issue Apr 30, 2016
@shu8
Copy link
Member

shu8 commented Apr 30, 2016

@enki-code dunno if this fixes your problem... but I've tweaked the script a bit to properly check the tag, and it to all tags. Can you reinstall and check if it's fixed for you? :)

@mezmi
Copy link
Contributor Author

mezmi commented Apr 30, 2016

Yay!! It's a dream come true. I love it.

@mezmi mezmi closed this as completed Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants