Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rails_env / unicorn_env / app_env are redundant or undocumented #46

Closed
aspiers opened this issue Mar 3, 2013 · 4 comments · Fixed by #70
Closed

rails_env / unicorn_env / app_env are redundant or undocumented #46

aspiers opened this issue Mar 3, 2013 · 4 comments · Fixed by #70

Comments

@aspiers
Copy link
Contributor

aspiers commented Mar 3, 2013

It's not at all clear why we need three variables which apparently serve the same purpose:

  • rails_env
  • unicorn_env
  • app_env

If they are really all necessary and serve different purposes then they should be documented properly. Otherwise they should be collapsed to just one variable, or two at most (since I can just about imagine that someone might want unicorn_env to have a different value to rails_env).
@aspiers aspiers mentioned this issue Mar 3, 2013
Closed
@vitoravelino
Copy link

Hey @aspiers! I just saw that I can pass params through the command line and access them inside the deploy file. That would solve that problem that I had without having to change anything at all.

But I agree that those 3 variables look the same. 👍 to this issue.

@aspiers aspiers mentioned this issue Aug 19, 2013
Closed
@aspiers
Copy link
Contributor Author

aspiers commented Aug 19, 2013

I have investigated, and actually they are not the same. I also found a bug with app_env which had independently been reported as #64. I'm working on a fix for all this now ...

@sfsekaran
Copy link
Contributor

@aspiers Is this issue closable, then?

@aspiers
Copy link
Contributor Author

aspiers commented Aug 19, 2013

No, it's better to wait until it's resolved before closing.

aspiers pushed a commit to aspiers/capistrano-unicorn that referenced this issue Aug 20, 2013
Accurately document unicorn_env, app_env, and unicorn_config_filename…
0923be8 
… variables

This is the first step towards resolving sosedoff#46 and sosedoff#64.
aspiers pushed a commit to aspiers/capistrano-unicorn that referenced this issue Aug 20, 2013
Make unicorn_env default to rails_env or 'production'
dcbb33d 
This contributes towards resolving sosedoff#46 and sosedoff#64.
aspiers pushed a commit to aspiers/capistrano-unicorn that referenced this issue Aug 20, 2013
Rename app_env to unicorn_rack_env and fix default value
6ae5b37 
This is the final commit in the series which fixes sosedoff#46.
@aspiers aspiers mentioned this issue Aug 20, 2013
Merged
aspiers pushed a commit to aspiers/capistrano-unicorn that referenced this issue Aug 22, 2013
Accurately document unicorn_env, app_env, and unicorn_config_filename…
5971bae 
… variables

This is the first step towards resolving sosedoff#46 and sosedoff#64.
aspiers pushed a commit to aspiers/capistrano-unicorn that referenced this issue Aug 22, 2013
Make unicorn_env default to rails_env or 'production'
63933b6 
This contributes towards resolving sosedoff#46 and sosedoff#64.
aspiers pushed a commit to aspiers/capistrano-unicorn that referenced this issue Aug 22, 2013
Rename app_env to unicorn_rack_env and fix default value
748e857 
This is the final commit in the series which fixes sosedoff#46.
aspiers pushed a commit to aspiers/capistrano-unicorn that referenced this issue Sep 2, 2013
Accurately document unicorn_env, app_env, and unicorn_config_filename…
6e91a25 
… variables

This is the first step towards resolving sosedoff#46 and sosedoff#64.
aspiers pushed a commit to aspiers/capistrano-unicorn that referenced this issue Sep 2, 2013
Make unicorn_env default to rails_env or 'production'
883b1f6 
This contributes towards resolving sosedoff#46 and sosedoff#64.
aspiers pushed a commit to aspiers/capistrano-unicorn that referenced this issue Sep 2, 2013
Rename app_env to unicorn_rack_env and fix default value
4a93a19 
This is the final commit in the series which fixes sosedoff#46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix multiple issues relating to variables aspiers/capistrano-unicorn
3 participants
@aspiers @sfsekaran @vitoravelino