Explain Query button is potentially misleading

[tim-ings-vgw]

Hey, just wanted to bring up that the "Explain Query" button is potentially misleading and could cause accidental loss of data as it actually runs EXPLAIN ANALYZE not just EXPLAIN as the button label initially suggests.

Relevant code here:

pgweb/pkg/api/api.go

Line 284 in 9d1a3fd

HandleQuery(fmt.Sprintf("EXPLAIN ANALYZE %s", query), c)

Version v0.11.7

[sosedoff]

Yeah you're right, though i don't know what the better UX would be for this functionality: i don't really want to have another button to run explain in the UI.

I suppose this could be achieved with a dropdown-style button that includes EXPLAIN / EXPLAIN ANALYZE options. Alternatively, we can check if selected query has any write operations (INSERT/UPDATE/etc) and confirm if user wants to perform the operation.

Thoughts?

[tim-ings-vgw]

Thanks for adding this to your 0.12.0 milestone, your suggestion of a dropdown button seems like a good approach to me.

[sosedoff]

This one is merger into master already!