Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No default for update and priority #14

Closed
owenbendavies opened this issue May 1, 2013 · 3 comments
Closed

No default for update and priority #14

owenbendavies opened this issue May 1, 2013 · 3 comments

Comments

@owenbendavies
Copy link
Contributor

I was wandering what the reasoning behind having a default for update and priority when these are not required fields?

If there is no real reason, I may make a pull request to get rid of them unless specifically set. Just wanted to check if there would be any objections before doing the work?

@sosedoff
Copy link
Owner

sosedoff commented May 1, 2013

@obduk i dont remember the reasoning, probably it was sitting in the code since the very first commit i made
3 years ago: https://github.com/sosedoff/xml-sitemap/blob/82a135729b4e4398c5a29908bbdc9e0c5710e8a1/lib/xml-sitemap.rb

no objections here, but make sure that everything works as usual.

@owenbendavies
Copy link
Contributor Author

Ok, will write tests.

@owenbendavies
Copy link
Contributor Author

Pull requested #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants