Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create translation from existing publication broken #160

Closed
ryanfb opened this issue Mar 24, 2016 · 2 comments
Closed

Create translation from existing publication broken #160

ryanfb opened this issue Mar 24, 2016 · 2 comments

Comments

@ryanfb
Copy link
Member

ryanfb commented Mar 24, 2016

Only on dev: https://sosol.airbrake.io/projects/20922/groups/1646400618549190995/notices/1646400615411431374

NoMethodError: undefined method `content' for nil:NilClass
app/models/hgv_trans_identifier.rb:102 in stub_text_structure
app/models/hgv_trans_identifier.rb:57 in new_from_template
app/controllers/identifiers_controller.rb:30 in create
@ryanfb
Copy link
Member Author

ryanfb commented Mar 24, 2016

Potentially a bug with reprints/associations, happened with a publication that had DDB identifier: papyri.info/ddbdp/bgu;15;2472
If I create a publication from that identifier, I get the message: This text is reprinted in papyri.info/ddbdp/bgu;1;239v, which is not associated with this publication (possibly a bug).
So the is_reprinted? filter in HGVTransIdentifier#related_text results in no related text being found.

@ryanfb
Copy link
Member Author

ryanfb commented Mar 29, 2016

Should probably just move HGVTransIdentifier#related_text to the Publication model, and only show the "create translation" link/button if it's not nil.

@ryanfb ryanfb removed the dev.papyri label Mar 30, 2016
@ryanfb ryanfb closed this as completed in d46d9e9 Apr 4, 2016
ryanfb added a commit that referenced this issue Jun 27, 2016
… text in HGVTransIdentifier.new_from_template (see #160 #172)
ryanfb added a commit that referenced this issue Jun 27, 2016
ryanfb added a commit that referenced this issue Jun 27, 2016
… text in HGVTransIdentifier.new_from_template (see #160 #172)
ryanfb added a commit that referenced this issue Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant