Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache/fallback for schema URLs in JRubyXML JARVValidators #207

Closed
ryanfb opened this issue Jun 28, 2017 · 2 comments
Closed

Cache/fallback for schema URLs in JRubyXML JARVValidators #207

ryanfb opened this issue Jun 28, 2017 · 2 comments

Comments

@ryanfb
Copy link
Member

ryanfb commented Jun 28, 2017

Currently, if the URL goes down, this can cause tests (or a new server instance) to bubble up Java::JavaIo::IOException errors.

We should handle this gracefully instead. Potentially we could cache the schemas in Git and fallback to that, or maybe we could fallback to e.g. the Wayback Machine?

@ryanfb
Copy link
Member Author

ryanfb commented Jul 9, 2018

This can also result in a Java::JavaNet::ConnectException being raised from the verifier_factory.compileSchema calls in lib/jruby_xml.rb (called from e.g. Identifier#is_valid_xml?).

@ryanfb
Copy link
Member Author

ryanfb commented Jul 9, 2018

See also #117 (Use schema URL used for validation in data templates)

@ryanfb ryanfb closed this as completed in e910e44 Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant