Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dust off and nuke emc plugin from orbit #257

Closed
bmr-cymru opened this issue Apr 4, 2014 · 7 comments
Closed

Dust off and nuke emc plugin from orbit #257

bmr-cymru opened this issue Apr 4, 2014 · 7 comments
Assignees
Milestone

Comments

@bmr-cymru
Copy link
Member

The emc plugin has a range of problems:

  • Interacts with terminal ignoring --batch
  • dated API usage
  • Questionable data collection (opaque binary data with no public spec)

Filing issue as a placeholder for a full review.

@bmr-cymru bmr-cymru modified the milestone: 3.2 Apr 14, 2014
@bmr-cymru bmr-cymru self-assigned this Apr 14, 2014
@adam-stokes adam-stokes modified the milestone: 3.2 Apr 15, 2014
@adam-stokes adam-stokes modified the milestones: 3.2, 3.3 Aug 19, 2014
@adam-stokes
Copy link

I think we can simplify this plugin a bit, removing the prints and other cruft.. I think it can be easily updated to use the latest api as well. The questionable data collection point though is probably what we want to decide if we care about or not

Im willing to update this plugin if @bmr-cymru decides to keep it

@bmr-cymru
Copy link
Member Author

The ideas I had were roughly:

  • split the plugin up so that separate EMC products are in separate plugins
  • Remove all the report text cruft - I really don't see a need for this
  • The interactive prompting is a problem & needs to die. I started working on a design for an interactive prompts API but it's not implemented yet; the short version is that if a plugin requests an option that's not been set and we're not in --batch mode it will generate an interactive prompt. I can see this being useful in a few places.

@adam-stokes
Copy link

i have little to no knowledge of EMC products, maybe we can email the author directly and see if he's willing to re-work it?

@bmr-cymru
Copy link
Member Author

I'd rather it was someone with good knowledge of sos - I'm happy to do it (I've a passing familiarity with most EMC stuff ;-))

@adam-stokes
Copy link

sounds good to meh

bmr-cymru added a commit that referenced this issue Sep 18, 2014
Related: #257.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
bmr-cymru added a commit that referenced this issue Sep 18, 2014
Related: #257.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
bmr-cymru added a commit that referenced this issue Sep 18, 2014
Move PowerPath functionality into a new powerpath plugin and
remove the (now empty) EMC plugin.

Fixes: #257.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
@bmr-cymru
Copy link
Member Author

This is mostly fixed now; just the interactive prompting in navicli left.

@adam-stokes
Copy link

👍 yay

ddstreet pushed a commit to ddstreet/sos that referenced this issue Apr 15, 2016
Related: sosreport#257.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
ddstreet pushed a commit to ddstreet/sos that referenced this issue Apr 15, 2016
Related: sosreport#257.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
ddstreet pushed a commit to ddstreet/sos that referenced this issue Apr 15, 2016
Move PowerPath functionality into a new powerpath plugin and
remove the (now empty) EMC plugin.

Fixes: sosreport#257.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants