Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[networking] netstat truncates IPv6 addresses #734

Closed
pmoravec opened this issue Jan 18, 2016 · 4 comments
Closed

[networking] netstat truncates IPv6 addresses #734

pmoravec opened this issue Jan 18, 2016 · 4 comments

Comments

@pmoravec
Copy link
Contributor

netstat -neopa truncates IPv6 addresses. Option -W / -T for net-tools version >=2 / <2 should be added to fix it.

@bmr-cymru
Copy link
Member

The real problem here is the need for separate switches for different versions... It's doable but distinctly ugly :-(

@pmoravec
Copy link
Contributor Author

pmoravec commented Feb 2, 2016

One option is command switches based on net-tools version, another is collect both commands outputs and either store them, or keep just the relevant one.

In this option, one gotcha is netstat -T on version >=2 has return value zero, so one would have to check netstat_output['output'][0] starting by netstat: invalid option.

@bmr-cymru
Copy link
Member

You seem to think our package manager version checks work :-)

I don't like the idea of treating these as separate commands - to the user they're the same data and it's a quirk of distro history that the switches were once different (we can use suggest_filename to force the name to the old name so users will not see any change).

@bmr-cymru
Copy link
Member

OK so see also issue #763 - we can do this with the current package manager abstraction but it is eye-wateringly ugly :-)

I'll commit a fix for this issue first since the changes to the policy classes are likely to be extensive. That way downstreams that want to fix the netstat collection can cherry-pick that change without pulling in the rest.

bmr-cymru added a commit that referenced this issue Feb 10, 2016
The 'netstat -agn' command reports IPv4 and IPv6 group addresses
which may also be truncated - apply the -W/-T switch to this
command as well.

Related: #734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
karibou pushed a commit to karibou/sosreport that referenced this issue Feb 17, 2016
By default netstat will truncate addresses that are wider than
the current column width. Disable this to ensure that all IPv6
addresses can be captured in full.

On Red Hat a non-upstream option (-T) was added to versions
prior to 2.0 - handle these version checks in the RedHatNetworking
class and set the appropriate option for each.

Fixes sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
karibou pushed a commit to karibou/sosreport that referenced this issue Feb 17, 2016
The 'netstat -agn' command reports IPv4 and IPv6 group addresses
which may also be truncated - apply the -W/-T switch to this
command as well.

Related: sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
karibou pushed a commit to karibou/sosreport that referenced this issue Feb 17, 2016
By default netstat will truncate addresses that are wider than
the current column width. Disable this to ensure that all IPv6
addresses can be captured in full.

On Red Hat a non-upstream option (-T) was added to versions
prior to 2.0 - handle these version checks in the RedHatNetworking
class and set the appropriate option for each.

Fixes sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
karibou pushed a commit to karibou/sosreport that referenced this issue Feb 17, 2016
The 'netstat -agn' command reports IPv4 and IPv6 group addresses
which may also be truncated - apply the -W/-T switch to this
command as well.

Related: sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
ddstreet pushed a commit to ddstreet/sos that referenced this issue Apr 15, 2016
By default netstat will truncate addresses that are wider than
the current column width. Disable this to ensure that all IPv6
addresses can be captured in full.

On Red Hat a non-upstream option (-T) was added to versions
prior to 2.0 - handle these version checks in the RedHatNetworking
class and set the appropriate option for each.

Fixes sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
ddstreet pushed a commit to ddstreet/sos that referenced this issue Apr 15, 2016
The 'netstat -agn' command reports IPv4 and IPv6 group addresses
which may also be truncated - apply the -W/-T switch to this
command as well.

Related: sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
TurboTurtle pushed a commit to TurboTurtle/sos that referenced this issue Jul 13, 2016
By default netstat will truncate addresses that are wider than
the current column width. Disable this to ensure that all IPv6
addresses can be captured in full.

On Red Hat a non-upstream option (-T) was added to versions
prior to 2.0 - handle these version checks in the RedHatNetworking
class and set the appropriate option for each.

Fixes sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
TurboTurtle pushed a commit to TurboTurtle/sos that referenced this issue Jul 13, 2016
The 'netstat -agn' command reports IPv4 and IPv6 group addresses
which may also be truncated - apply the -W/-T switch to this
command as well.

Related: sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
TurboTurtle pushed a commit to TurboTurtle/sos that referenced this issue Jul 13, 2016
By default netstat will truncate addresses that are wider than
the current column width. Disable this to ensure that all IPv6
addresses can be captured in full.

On Red Hat a non-upstream option (-T) was added to versions
prior to 2.0 - handle these version checks in the RedHatNetworking
class and set the appropriate option for each.

Fixes sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
TurboTurtle pushed a commit to TurboTurtle/sos that referenced this issue Jul 13, 2016
The 'netstat -agn' command reports IPv4 and IPv6 group addresses
which may also be truncated - apply the -W/-T switch to this
command as well.

Related: sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
poornimakshirsagar pushed a commit to poornimakshirsagar/sos that referenced this issue Jan 5, 2017
By default netstat will truncate addresses that are wider than
the current column width. Disable this to ensure that all IPv6
addresses can be captured in full.

On Red Hat a non-upstream option (-T) was added to versions
prior to 2.0 - handle these version checks in the RedHatNetworking
class and set the appropriate option for each.

Fixes sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
poornimakshirsagar pushed a commit to poornimakshirsagar/sos that referenced this issue Jan 5, 2017
The 'netstat -agn' command reports IPv4 and IPv6 group addresses
which may also be truncated - apply the -W/-T switch to this
command as well.

Related: sosreport#734.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants