Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gluster_block] Added new plugin gluster_block #1041

Merged
merged 1 commit into from Jun 28, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 39 additions & 0 deletions sos/plugins/gluster_block.py
@@ -0,0 +1,39 @@
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.

# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.

# You should have received a copy of the GNU General Public License along
# with this program; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
import glob
from sos.plugins import Plugin, RedHatPlugin


class GlusterBlock(Plugin, RedHatPlugin):
"""Gluster Block"""

plugin_name = 'gluster_block'
profiles = ('storage',)
packages = ("gluster-block",)
files = ("/usr/sbin/gluster-block",)

def setup(self):

# collect logs - apply log_size for any individual file
# all_logs takes precedence over logsize
if not self.get_option("all_logs"):
limit = self.get_option("log_size")
else:
limit = 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks for implementing log limiting.

if limit:
for f in glob.glob("/var/log/gluster-block/*.log"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. This is ugly, but it is in keeping with other plugins that try to work around the current limits API shortcomings. We can clean it up later when those are addressed.

self.add_copy_spec(f, limit)
else:
self.add_copy_spec("/var/log/gluster-block")