[networking] call ethtool for proper vlan device names

[pmoravec]

Dont rely on device names from "ip -o link" output where the names
contain also physical device name. Rather get the list of device names
from listing /sys/class/net/ directory.

Resolves: #1458

Signed-off-by: Pavel Moravec pmoravec@redhat.com

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname email@example.com?

[pmoravec]

Kudos to Jonathan Maxwell from Red Hat who wrote the patch.

[bmr-cymru]

I'd like a better solution for trawling the namespace, but we can go with this if there's nothing forthcoming in time.

I think it's actually quite easy to implement ns_listdir(ns, dir) natively in Python here.

[bmr-cymru]

Is there a reason not to use os.listdir() here? It is typically cleaner than shelling out to ls...

[bmr-cymru]

Ah, OK. The ns prefix. I wonder if there isn't a better way to do that, it's kinda fugly...

[pmoravec]

Yeah, haven't found a direct pythonic way outside calling shell. I can add a comment if it clarifies the code..?