[gdm] Ubuntu calls gdm, gdm3 #1937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmoravec
reviewed
Feb 12, 2020
sos/plugins/gdm.py
Outdated
| @@ -15,7 +15,7 @@ class Gdm(Plugin, RedHatPlugin, DebianPlugin, UbuntuPlugin): | |||
|
|
|||
| plugin_name = 'gdm' | |||
| profiles = ('desktop',) | |||
| packages = ('gdm',) | |||
| packages = ('gdm', 'gd3',) | |||
There was a problem hiding this comment.
Isn't the added package name rather gdm3?
There was a problem hiding this comment.
Alright, I need to slow down.
Nice catch!
Resolves: sosreport#1937 Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
pmoravec
approved these changes
Feb 12, 2020
slashdd
reviewed
Feb 12, 2020
| @@ -15,7 +15,7 @@ class Gdm(Plugin, RedHatPlugin, DebianPlugin, UbuntuPlugin): | |||
|
|
|||
| plugin_name = 'gdm' | |||
| profiles = ('desktop',) | |||
| packages = ('gdm',) | |||
| packages = ('gdm', 'gdm3',) | |||
|
|
|||
| def setup(self): | |||
| self.add_copy_spec("/etc/gdm/*") | |||
There was a problem hiding this comment.
Does all the "gdm" operation applies to the gdm3 package ? (e.g. gdm3 comes with /etc/gdm3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1937
Signed-off-by: Bryan Quigley bryan.quigley@canonical.com
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines
Closes: #ISSUENUMBERincluded in an independent line?Resolves: #PRNUMBERincluded in an independent line?