Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cdk fixes #2387

Closed
wants to merge 2 commits into from
Closed

Cdk fixes #2387

wants to merge 2 commits into from

Conversation

freyes
Copy link
Contributor

@freyes freyes commented Jan 27, 2021 •
edited

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • If this commit closes an existing issue, is the line Closes: #ISSUENUMBER included in an independent line?
  • If this commit resolves an existing pull request, is the line Resolves: #PRNUMBER included in an independent line?

@freyes
[kubernetes] Fix CDK related file paths
a126d57 
The `files` property is used to determined if it's the kubernetes
master node is where the plugin is runnig since it's the only node
capable of running kubectl. In Ubuntu CDK environments the file that's
only available in the master is /root/cdk/cdk_addons_kubectl_config
while /root/cdk/kubeproxyconfig is also available in the workers.

Signed-off-by: Felipe Reyes <felipe.reyes@canonical.com>
slashdd
slashdd approved these changes Jan 27, 2021
View reviewed changes
Copy link

@slashdd slashdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

slashdd
slashdd approved these changes Jan 27, 2021
View reviewed changes
Copy link

@slashdd slashdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

TurboTurtle
TurboTurtle reviewed Jan 27, 2021
View reviewed changes
Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, though please add Resolves: #2387 to the last commit per the Contributor Guidelines

@freyes
[kubernetes] Add cdk.master.auth-webhook to journal collection
22fbfe9 
In Ubuntu CDK when the deployed with Keystone authentication the
service cdk.master.auth-webhook is deployed to handle that integration
this change includes this unit to collect its journal.

Resolves: sosreport#2387

Signed-off-by: Felipe Reyes <felipe.reyes@canonical.com>
@freyes
Copy link
Contributor Author

freyes commented Jan 28, 2021

Ack, though please add Resolves: #2387 to the last commit per the Contributor Guidelines

done ;-) .

@freyes freyes deleted the cdk-fixes branch April 12, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboTurtle TurboTurtle TurboTurtle approved these changes

@pmoravec pmoravec pmoravec approved these changes

@slashdd slashdd slashdd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freyes @TurboTurtle @pmoravec @slashdd