Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[candlepin/foreman] call psql with --no-password to avoid waiting on input #2429

Closed
wants to merge 2 commits into from
Closed

[candlepin/foreman] call psql with --no-password to avoid waiting on input #2429

wants to merge 2 commits into from

Conversation

jjansky1
Copy link
Contributor

@jjansky1 jjansky1 commented Mar 1, 2021 •
edited

Resolved: #2429
Related: #2422
Closes: #2421

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • If this commit closes an existing issue, is the line Closes: #ISSUENUMBER included in an independent line?
  • If this commit resolves an existing pull request, is the line Resolves: #PRNUMBER included in an independent line?

@jjansky1
candlepin: call psql with --no-password to avoid waiting on input
21360a3 
Signed-off-by: Jan Jansky <jjansky@redhat.com>
pmoravec
pmoravec reviewed Mar 1, 2021
View reviewed changes
sos/plugins/foreman.py Outdated Show resolved Hide resolved
@jjansky1
foreman: call psql with --no-password to avoid waiting on input
a76f088 
Resolved: sosreport#2429
Related: sosreport#2422
Closes: sosreport#2421

Signed-off-by: Jan Jansky <jjansky@redhat.com>
@jjansky1 jjansky1 force-pushed the jjansky1-foreman/candlepin-timeout branch from 260f629 to a76f088 Compare March 1, 2021 13:32
TurboTurtle pushed a commit that referenced this pull request Mar 2, 2021
@jjansky1 @TurboTurtle
[foreman] call psql with --no-password to avoid waiting on input
ea9be29 
Backport #2422 to legacy-3.9.

Resolves: #2429
Closes: #2421

Signed-off-by: Jan Jansky <jjansky@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
@TurboTurtle
Copy link
Member

Merged into legacy-3.9 via ea9be29

@TurboTurtle TurboTurtle closed this Mar 2, 2021
@jjansky1
Copy link
Contributor Author

Hello,
it seems only commit below was merged

foreman: call psql with --no-password to avoid waiting on input (a76f088)

can i get please merged also commit below?

candlepin: call psql with --no-password to avoid waiting on input (21360a3)

Thank you in advance (sorry for missing [] on plugin name in commit message)
JJ

jjansky1 added a commit to jjansky1/sos that referenced this pull request Mar 16, 2021
@jjansky1
[foreman] call psql with --no-password to avoid waiting on input
47006eb 
Resolved: sosreport#2429
Related: sosreport#2422
Closes: sosreport#2421

Signed-off-by: Jan Jansky <jjansky@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboTurtle TurboTurtle TurboTurtle approved these changes

@pmoravec pmoravec pmoravec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjansky1 @TurboTurtle @pmoravec