Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulpcore] obfuscate two passwords from 'dynaconf list' #2583

Conversation

pmoravec
Copy link
Contributor

The command also prints content of /etc/pulp/settings.py
where we need to also obfuscate the SECRET_KEY and PASSWORD values.

Resolves: #2583

Signed-off-by: Pavel Moravec pmoravec@redhat.com


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • If this commit closes an existing issue, is the line Closes: #ISSUENUMBER included in an independent line?
  • If this commit resolves an existing pull request, is the line Resolves: #PRNUMBER included in an independent line?

The command also prints content of /etc/pulp/settings.py
where we need to also obfuscate the SECRET_KEY and PASSWORD values.

Resolves: sosreport#2583

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
@jjansky1
Copy link
Contributor

verified on reproducer

@TurboTurtle TurboTurtle merged commit ab12f34 into sosreport:master Jun 15, 2021
jjansky1 added a commit to jjansky1/sos that referenced this pull request Jun 15, 2021
The command also prints content of /etc/pulp/settings.py
where we need to also obfuscate the SECRET_KEY and PASSWORD values.

Related: sosreport#2583
Resolves: sosreport#2584

Signed-off-by: Jan Jansky <jjansky@redhat.com>
TurboTurtle pushed a commit that referenced this pull request Jun 15, 2021
The command also prints content of /etc/pulp/settings.py
where we need to also obfuscate the SECRET_KEY and PASSWORD values.

Related: #2583
Resolves: #2584

Signed-off-by: Jan Jansky <jjansky@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants