-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charmed_postgresql] Add Charmed PostgreSQL support #3651
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to make the same change with other places too
@acsgn can you rebase to |
0c4e328
to
7f09e87
Compare
looks good overall a heads up, we have a new PR (#3648) that we have been working on, that allows you to run a command as a user without using Furthermore, we prefer that any PR that comes through is squashed before we merge. |
626d4c2
to
6921953
Compare
good call and thanks for noticing that, I'll get that resolved in another PR |
Signed-off-by: Abdullah Cosgun <abdullah.cosgun@canonical.com>
6921953
to
5b4543e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on internal discussions and testing, this looks good now
import os | ||
import yaml | ||
|
||
from sos.report.plugins import Plugin, UbuntuPlugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems charmed-postgresql
is available on many distributions, per https://snapcraft.io/charmed-postgresql, but since "Users by distribution" shows just Ubuntu, we can have just UbuntuPlugin
until somebody wants otherwise.
Example output of the plugin can be seen at https://drive.google.com/drive/folders/1t1QOwzqwFTv140xvpaRpB5-kqRPOYth5?usp=sharing
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines