Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kea] New plugin for kea dhcp/ddns server #3655

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcastill
Copy link
Member

@jcastill jcastill commented Jun 6, 2024

This plugin captures config files and status of
the Kea DHCPv4/DHCPv6 and DDNS server by ISC.

Related: RHEL-40285


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3655
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

arif-ali commented Jun 7, 2024

You can add a UbuntuPlugin to this well

4 services that are possible

root@noble01:~# systemctl list-unit-files | grep kea
kea-ctrl-agent.service                       enabled         enabled
kea-dhcp-ddns-server.service                 enabled         enabled
kea-dhcp4-server.service                     enabled         enabled
kea-dhcp6-server.service                     enabled         enabled

The keactrl command doesn't seem to exist for Ubuntu.

We may as well do the postproc you're doing here in the main class where we're collecting /etc/kea and then add the Ubuntu stuff specifically there

@jcastill
Copy link
Member Author

The services are the same in RHEL/Fedora.
Apart from keactrl, what else is different in Ubuntu?

@arif-ali
Copy link
Member

The services are the same in RHEL/Fedora. Apart from keactrl, what else is different in Ubuntu?

From my initial research, I didnt find any other differences

@jcastill
Copy link
Member Author

jcastill commented Jul 3, 2024

New version with the comments addressed, hopefully. I tested the plugin in Ubuntu as well, to make sure the obfuscation was working as expected.

Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, thanks

minor nits

sos/report/plugins/kea.py Outdated Show resolved Hide resolved
sos/report/plugins/kea.py Show resolved Hide resolved
This plugin captures config files and status of
the Kea DHCPv4/DHCPv6 and DDNS server by ISC.

Related:  RHEL-40285

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants