Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kernel] Add plain 'dmesg' command to plugin #3658

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

jcastill
Copy link
Member

@jcastill jcastill commented Jun 10, 2024

PR #3657 added human readable timestamps to the dmesg command, but the command can be unreliable. This PR adds the plain 'dmesg' command capture again, to make sure that we still have an output with reliable
timestamps that can be easily converted to human readable in these cases where 'dmesg -T' could not be trusted.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

PR sosreport#3657 added human readable timestamps to the dmesg
command, but the command can be unreliable. This PR
adds the plain 'dmesg' command capture again, to make
sure that we still have an output with reliable
timestamps that can be easily converted to human readable
in these cases where 'dmesg -T' could not be trusted.

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3658
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

arif-ali commented Jun 10, 2024

I agree, that came in on the weekend, and merged pretty quickly, I would've said the same to have both

I tried to restart the test for 18.04, could be something new that was introduced with a new version of some library in 22.04 that needs solving with the snap to work with 18.04. I'll have a look as see what is going on.

But, it is unrelated to this change

@arif-ali
Copy link
Member

I have created #3659 to look at the snap issue, I'll go ahead and merge this

@arif-ali arif-ali merged commit b29d911 into sosreport:main Jun 10, 2024
26 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants