[reporting] html_report skips plugins .. with nonASCII #839
+19
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[reporting] html_report skips plugins that collected file with nonASCII character in their name Converting all html report strings to unicode with utf-8 encoding. Does not work ideally on py2 where the report does not skip a plugin but breaks encoding of most nonASCII characters. Resolves: sosreport#835 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
The patch works completely well on python3. On python2, when collecting That is due to the fact |
Seems a separate bug (outside reporting) |
|
Merged as commit 5e4991f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[reporting] html_report skips plugins that collected file with
nonASCII character in their name
Converting all html report strings to unicode with utf-8 encoding.
Does not work ideally on py2 where the report does not skip a plugin
but breaks encoding of most nonASCII characters.
Resolves: #835
Signed-off-by: Pavel Moravec pmoravec@redhat.com