Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bsplines! return OffsetArray #8

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Conversation

sostock
Copy link
Owner

@sostock sostock commented Aug 12, 2020

This makes the output of bsplines!(dest, args...) equivalent to that of bsplines(args...). The returned OffsetArray is a wrapper around dest.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files           6        6           
  Lines         428      428           
=======================================
  Hits          385      385           
  Misses         43       43           
Impacted Files Coverage Δ
src/bsplinebasis.jl 97.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22921a...8f589f7. Read the comment docs.

@sostock sostock merged commit 9423e97 into master Aug 12, 2020
@sostock sostock deleted the bsplines_inplace_array branch August 12, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants