Skip to content
This repository has been archived by the owner on Oct 3, 2021. It is now read-only.

Remove some warning suppression flags and lay the ground work for treating some warnings as errors #105

Merged
merged 8 commits into from
Nov 4, 2015
Merged

Remove some warning suppression flags and lay the ground work for treating some warnings as errors #105

merged 8 commits into from
Nov 4, 2015

Commits on Nov 4, 2015

  1. Revert "Change build system so that it always passes warning suppress… 

    …ion flags"

This reverts commit 4815a22.

This isn't necessary anymore since the benchmarks in ldv-consumption
have been fixed.
    Dan Liew committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    aa00eac View commit details
    Browse the repository at this point in the history

  2. Fix a benchmark that won't compile under Clang without 

    ``-Wno-return-type``.
    Dan Liew committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    6ab0e14 View commit details
    Browse the repository at this point in the history

  3. Introduce the concept of "warnings as errors" into the build system so 

    that we can have certain warnings treated as errors. Now we no longer
suppress -Wmain and instead pass -Werror=main so that incorrect main()
functions trigger a compiler error instead of a warning.
    Dan Liew committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    4f4c27e View commit details
    Browse the repository at this point in the history

  4. Fix a benchmark is ldv-races that would not compile under Clang 

    without -Wno-return-type
    Dan Liew committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    be1e71f View commit details
    Browse the repository at this point in the history

  5. Fix benchmark in loop-invgen that won't compile with Clang without 

    -Wno-return-type
    Dan Liew committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    78eeac2 View commit details
    Browse the repository at this point in the history

  6. Do not suppress -Wreturn-type. Doing so is not justifiable as it 

    is a good indicator of bad code.
    Dan Liew committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    1471f9a View commit details
    Browse the repository at this point in the history

  7. Do not suppress -Wuninitialized . Suppressing this warning is not 

    justifiable as it likely means there is undefined behaviour.
    Dan Liew committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    d93bec4 View commit details
    Browse the repository at this point in the history

  8. Add a note about using -Werror=implicit-function-declaration and 

    -Werror=implicit-int. I tried adding these but the benchmarks don't
compile with these set and it looks like a lot of work to fix these.
    Dan Liew committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    508a4a7 View commit details
    Browse the repository at this point in the history