Skip to content
This repository has been archived by the owner on Oct 3, 2021. It is now read-only.

fix labels of two termination benchmarks #292

Closed
wants to merge 5 commits into from
Closed

fix labels of two termination benchmarks #292

wants to merge 5 commits into from

Conversation

Heizmann
Copy link
Contributor

@Heizmann Heizmann commented Dec 3, 2016

  • Addition02_false-unreach-call_true-termination.c
    for n > 0 termination can be shown using the ranking function f(m, n)=n
    for n < 0 termination can be shown using the ranking function f(m, n)=-n

  • McCarthy91_false-unreach-call_true-termination.c
    Our tool does not provide a simple termination proof, however it is
    well-known that this algorithm is terminating and the implementation
    does not contain any "surprises" like e.g. operations with wrap-around arithmetic

- Addition02_false-unreach-call_true-termination.c
for n > 0 termination can be shown using the ranking function f(m, n)=n
for n < 0 termination can be shown using the ranking function f(m, n)=-n

- McCarthy91_false-unreach-call_true-termination.c
Our tool does not provide a simple termination proof, however it is
well-known that this algorithm is terminating and the implementation
does not contain any "surprises" like e.g. operations with wrap-around arithmetic
label of EvenOdd03 was already incorrect before my overflow fixes
(avoid that the large number of termination benchmarks in product-lines outweigts
other termination benchmarks)
(avoid that the large number of termination benchmarks in product-lines
outweigts other termination benchmarks)
… also recursive-simple to Termination-Recursive.set
Copy link
Member

@PhilippWendler PhilippWendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please split this PR into at least two: changing existing files in one PR, and adding termination labels to files in another? This would make it easier to review and discuss the changes.

When you rename files, please check whether they are listed in the blacklist in compare.sh and update their names there as well to prevent failure of the continuous integration check.
Also, please run check.py and fix any reported errors. Thanks!

@Heizmann
Copy link
Contributor Author

Heizmann commented Dec 3, 2016

I split this pull request into #293, #294, and #295.

@Heizmann Heizmann closed this Dec 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants