Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backgammon] Fix the number of legal_action_mask dimension. #1004

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

nissymori
Copy link
Collaborator

@nissymori nissymori commented Aug 19, 2023

The number of dimension of legal_action_mask should be src * 6 = 156 but it was src * 6 + 6 = 162

  • Fixed the dimension num of legal_action_mask and passed the test.
  • Translated some remaining Japanese comments into English.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #1004 (d9beb64) into main (9e34323) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
+ Coverage   86.02%   86.06%   +0.03%     
==========================================
  Files          53       53              
  Lines        5897     5897              
==========================================
+ Hits         5073     5075       +2     
+ Misses        824      822       -2     
Files Changed Coverage Δ
pgx/backgammon.py 99.07% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sotetsuk sotetsuk merged commit de0bb45 into main Aug 19, 2023
6 checks passed
@sotetsuk sotetsuk deleted the nissymori/fix/fix_backgammon_action branch August 19, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants