Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mahjong] Visualize game information #1027

Merged
merged 7 commits into from
Sep 8, 2023
Merged

Conversation

OkanoShinri
Copy link
Collaborator

@OkanoShinri OkanoShinri commented Aug 30, 2023

  • round
  • honba
  • riichi
  • score
  • 100-ten
  • 1000-ten
  • yama

temp0

@OkanoShinri OkanoShinri changed the title [Mahjong] Visualize game infomation [Mahjong] Visualize game information Aug 30, 2023
@OkanoShinri
Copy link
Collaborator Author

@sotetsuk
上の画像のように可視化できています
これで状態を確認する最低限のラインには達したと思います

このPRではmjxと同様の状態まで進めたいです

スクリーンショット 2023-08-31 012940

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1027 (385deb1) into main (328b406) will increase coverage by 0.45%.
Report is 3 commits behind head on main.
The diff coverage is 96.89%.

@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
+ Coverage   89.10%   89.56%   +0.45%     
==========================================
  Files          54       54              
  Lines        5895     6006     +111     
==========================================
+ Hits         5253     5379     +126     
+ Misses        642      627      -15     
Files Changed Coverage Δ
pgx/_src/visualizer.py 83.20% <ø> (ø)
pgx/_mahjong/_mahjong2.py 94.14% <96.87%> (+0.13%) ⬆️
pgx/_src/dwg/mahjong.py 59.82% <96.90%> (+6.98%) ⬆️

... and 2 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@OkanoShinri
Copy link
Collaborator Author

終了条件ちゃんと作れていないのでおかしくなってますが、可視化こんな感じでまとまりました
temp99

@OkanoShinri OkanoShinri merged commit 719813f into main Sep 8, 2023
6 checks passed
@OkanoShinri OkanoShinri deleted the okano/feat/mahjong-info branch September 8, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant