Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2048] Fix reward overflow #1034

Merged
merged 7 commits into from
Sep 12, 2023
Merged

[2048] Fix reward overflow #1034

merged 7 commits into from
Sep 12, 2023

Conversation

sotetsuk
Copy link
Owner

@sotetsuk sotetsuk commented Sep 12, 2023

This state transition returns -92 as reward due to overflow.
This PR changes int8 to int32 and update version to v1.

image image

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #1034 (5ffc667) into main (4c899ab) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

❗ Current head 5ffc667 differs from pull request most recent head 5e941de. Consider uploading reports for the commit 5e941de to get more accurate results

@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
- Coverage   89.56%   89.55%   -0.01%     
==========================================
  Files          54       54              
  Lines        6006     6005       -1     
==========================================
- Hits         5379     5378       -1     
  Misses        627      627              
Files Changed Coverage Δ
pgx/play2048.py 95.60% <75.00%> (-0.05%) ⬇️

@sotetsuk sotetsuk merged commit e8e4d53 into main Sep 12, 2023
4 checks passed
@sotetsuk sotetsuk deleted the sotetsuk/fix/2048-bug branch September 12, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant