Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backgammon] Add description to the playable_dice_count_vec #1047

Merged

Conversation

nissymori
Copy link
Collaborator

@nissymori nissymori commented Sep 24, 2023

I added some comments to clarify the contents of the feature playable_dice_count_vec.

Together with #1046 , it will solve the issue on the understandability of the feature.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #1047 (a346fd2) into main (2041a6d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files          54       54           
  Lines        6011     6011           
=======================================
  Hits         5402     5402           
  Misses        609      609           
Files Changed Coverage Δ
pgx/backgammon.py 99.07% <ø> (ø)

@sotetsuk sotetsuk merged commit 4962c49 into main Sep 28, 2023
6 checks passed
@sotetsuk sotetsuk deleted the nissymori/tidy/additional_comment_on_backgammon_feature branch September 28, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants