Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 API #1058

Merged
merged 49 commits into from
Nov 6, 2023
Merged

v2 API #1058

merged 49 commits into from
Nov 6, 2023

Conversation

sotetsuk
Copy link
Owner

@sotetsuk sotetsuk commented Oct 4, 2023

envs

  • animal_shogi
  • backgammon
  • bridge_bidding
  • chess
  • connect_four
  • gardner_chess
  • go
  • hex
  • kuhn_poker
  • leduc_holdem
  • othello
  • play2048
  • shogi
  • sparrow_mahjong
  • tic_tac_toe
  • minatar

API tests

  • usage1: key=key for deterministic env (redundant but ok)
  • usage2: key=None for deterministic env (ok)
  • usage1: key=key for stochastic env (ok)
    • no error
    • different key gives different results
    • same key gives same results
  • usage3: key=None for stochastic env (wrong)

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1058 (d6c633a) into main (b91afce) will decrease coverage by 0.05%.
The diff coverage is 99.44%.

❗ Current head d6c633a differs from pull request most recent head 502f9a6. Consider uploading reports for the commit 502f9a6 to get more accurate results

@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
- Coverage   87.61%   87.56%   -0.05%     
==========================================
  Files          54       54              
  Lines        5918     5913       -5     
==========================================
- Hits         5185     5178       -7     
- Misses        733      735       +2     
Files Coverage Δ
pgx/__init__.py 100.00% <100.00%> (ø)
pgx/_src/api_test.py 98.95% <100.00%> (+0.12%) ⬆️
pgx/_src/visualizer.py 83.20% <100.00%> (ø)
pgx/animal_shogi.py 99.00% <100.00%> (-0.01%) ⬇️
pgx/backgammon.py 99.06% <100.00%> (-0.02%) ⬇️
pgx/bridge_bidding.py 82.42% <100.00%> (ø)
pgx/chess.py 99.50% <100.00%> (-0.01%) ⬇️
pgx/connect_four.py 97.59% <100.00%> (-0.03%) ⬇️
pgx/core.py 70.22% <100.00%> (ø)
pgx/gardner_chess.py 99.30% <100.00%> (-0.01%) ⬇️
... and 11 more

... and 3 files with indirect coverage changes

This reverts commit 506f6e4.
This reverts commit 31bf233.
@sotetsuk sotetsuk changed the title WIP: [v2 API] v2 API Oct 4, 2023
@sotetsuk sotetsuk merged commit 405ffc5 into main Nov 6, 2023
2 checks passed
@sotetsuk sotetsuk deleted the sotetsuk/v2 branch November 6, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant