Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Use int32 instead of int8/16 #1074

Merged
merged 5 commits into from
Nov 6, 2023
Merged

[API] Use int32 instead of int8/16 #1074

merged 5 commits into from
Nov 6, 2023

Conversation

sotetsuk
Copy link
Owner

@sotetsuk sotetsuk commented Nov 2, 2023

Found some buggy behaviors in int8 (e.g., failed to indexing via int8 var)

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1074 (37748df) into main (922a45e) will not change coverage.
The diff coverage is 99.52%.

@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files          54       54           
  Lines        5900     5900           
=======================================
  Hits         5194     5194           
  Misses        706      706           
Files Coverage Δ
pgx/_src/api_test.py 98.83% <100.00%> (ø)
pgx/_src/chess_utils.py 100.00% <100.00%> (ø)
pgx/_src/gardner_chess_utils.py 100.00% <100.00%> (ø)
pgx/_src/shogi_utils.py 99.31% <100.00%> (ø)
pgx/animal_shogi.py 99.00% <100.00%> (ø)
pgx/backgammon.py 99.07% <100.00%> (ø)
pgx/chess.py 99.49% <100.00%> (ø)
pgx/connect_four.py 97.61% <100.00%> (ø)
pgx/experimental/bridge_bidding.py 0.00% <ø> (ø)
pgx/gardner_chess.py 99.30% <100.00%> (ø)
... and 10 more

@sotetsuk sotetsuk changed the title [API] Use int32 instead of int8 [API] Use int32 instead of int8/16 Nov 2, 2023
@sotetsuk sotetsuk merged commit 48cc3a1 into main Nov 6, 2023
4 checks passed
@sotetsuk sotetsuk deleted the sotetsuk/api/rm-int8 branch November 6, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant