[Chess] Fix _possible_piece_positions when castling
#983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kingside and queenside castling
|
Thank you for sending PR! 🤟 |
|
As your description in #982 sounds reasonable. I'll merge this PR immediately when
Feel free to let me know. I'm happy to help you to merge this PR! 👍 |
|
Hi, I added a new test under the buggy_test part and applied the formatter |
|
Thanks a lot! I'll review and merge in a few days! 👍 🙏 |
|
LGTM! 👍 |
sotetsuk
changed the title
_possible_piece_positions when castling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kingside and queenside castling