This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
Fix getContent() not to use mapName for Unix #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you not using openExisting, the program will crash if you try to access same file after you search twice one after the another. Thus, I would not advise to go through with this change. Also some of the unit test will fail due to file access error too. |
|
I see why we need to have some change to the code. @sotheanith please check this reference. |
Since MemoryMappedFile can't be name due to compatibility issues with other OS, dispose of MemoryMappedFile after reading from it through the implementation of IDisposable
|
This needs further enhancement later, using custom MemoryMappedFile managers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had errors running the program
So I reverted the change on streamReader in getContent()
since mapName used in OpenExisting() is not supported in Unix