added: command plugin to download model files. #79
Conversation
| @@ -0,0 +1,60 @@ | |||
| // swift-tools-version: 5.9 | |||
| import PackageDescription | |||
There was a problem hiding this comment.
In Soto (as with SwiftNIO) we look to support the last three versions of Swift. So for the moment that'd be 5.8, 5.9 and 5.10. Currently with your setup the download plugin is only available for 5.9, not 5.10. I would instead create a Package.@swift-5.8.swift which is a copy of the current Package.swift and make this version the default Package.swift
There was a problem hiding this comment.
So, with the current package setup, if the current Swift version doesn't match any version-specific manifest, the package manager will pick the manifest with the most compatible tools version. This means the package manager will pick Package.swift for Swift 5.8 and Package@swift-5.9.swift for Swift 5.9 and above, as its tools version will be most compatible with future versions of the package manager. I read this in the documentation here.
In terms of readability and maintainability, I agree with your approach of keeping the 5.8 version tag instead of 5.9.
This pull request addresses issue #62.
Changes Made:
Additional Notes:
I attempted to implement gatekeeping using availability, but network permissions need to be set at the package level, which is only available from Swift toolchain 5.9 onward.