Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if the content and the wrapper exists before computing the sizes #123

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

alexnaiman
Copy link

I had some problems with the functions scrollToBottom and refresh calling them from componentDIdMount()/componentDidUpdate() that showed that the container field of the object was null.
35433320_1968985546486676_9056465179620933632_n

I believe that one should verify if the fields are defined and if not to initialise the requested variables with zero (width and height).

Alexandru Naiman and others added 6 commits June 19, 2018 01:36
…s of the container avoiding componentDidMount errors when calling scrollToBottom/refresh
…s of the container avoiding componentDidMount errors when calling scrollToBottom/refresh
…efore-computing-sizes' into checking-if-the-content-exists-before-computing-sizes
src/js/ScrollArea.jsx Outdated Show resolved Hide resolved
src/js/ScrollArea.jsx Outdated Show resolved Hide resolved
@souhe
Copy link
Owner

souhe commented Jul 5, 2018

@alexnaiman thanks for your work. I left to minor comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants