Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance How to use it documentation #27

Merged

Conversation

GianDeManincor
Copy link
Contributor

@GianDeManincor GianDeManincor commented Jan 25, 2024

I am improving and organizing the How to use it documentation.

My idea was to create a subtitles for each topic:

  1. Add a dependency - explanation about the add-dep.
  2. Confirm de changes - explanation about the commit.
  3. Revert the changes - explanation about the rollback.

Signed-off-by: Gian de Manincor <gianmanincor@gmail.com>
@GianDeManincor GianDeManincor force-pushed the adding-commit-and-rollback-documentation branch from 0db73b1 to 73d5581 Compare January 25, 2024 22:06
Signed-off-by: Gian de Manincor <gianmanincor@gmail.com>
@GianDeManincor GianDeManincor marked this pull request as ready for review January 26, 2024 16:28
README.adoc Show resolved Hide resolved
@dearrudam dearrudam self-requested a review January 26, 2024 22:01
@@ -14,6 +14,8 @@ Facilitate manipulation such as managing POM dependencies through CLI (command l

== How to use it

==== Add a dependency
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
==== Add a dependency
=== Add a dependency

@@ -41,6 +43,37 @@ Then you'll be able to perform the plugin by its prefix:
mvn pom-editor:add-dep -Dgav='org.junit.jupiter:junit-jupiter:5.9.2' -Dscope=test
----

==== Confirm the changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
==== Confirm the changes
=== Confirm the changes

[source,sh]
$ mvn pom-editor:commit

==== Revert the changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
==== Revert the changes
=== Revert the changes

@@ -14,6 +14,8 @@ Facilitate manipulation such as managing POM dependencies through CLI (command l

== How to use it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[TIP]
===============================
In order to make easier the plugin utilization we can register the groupId into the `settings.xml` like the snipped code below:
[source,xml]
----
<settings >
<!-- snipped -->
<pluginGroups>
<pluginGroup>br.org.soujava</pluginGroup>
</pluginGroups>
<!-- snipped -->
</settings>
----
With that, we will be able to perform the plugin by using its prefix.
So, instead of to perform the plugin by the following command:
[source, sh]
----
mvn br.org.soujava:pom-editor-maven-plugin:<GOAL>
----
We may perform it just providing its prefix like below:
[source, sh]
----
mvn pom-editor:<GOAL>
----
In the documentation, we'll assume that you have done this configuration.
===============================

Copy link
Contributor

@dearrudam dearrudam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know for any doubts!

@dearrudam dearrudam dismissed their stale review January 27, 2024 00:18

I'll be add the suggestions later

@dearrudam dearrudam merged commit 8d186bf into soujava:main Jan 27, 2024
3 checks passed
@dearrudam
Copy link
Contributor

@GianDeManincor, thanks for the contribution!

@GianDeManincor GianDeManincor deleted the adding-commit-and-rollback-documentation branch January 27, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants