Skip to content
This repository has been archived by the owner on Dec 26, 2019. It is now read-only.

Wrong label on when review is just requested #1

Closed
soulim opened this issue May 11, 2018 · 1 comment
Closed

Wrong label on when review is just requested #1

soulim opened this issue May 11, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@soulim
Copy link
Owner

soulim commented May 11, 2018

Label "Rejected" is displayed when no review is actually left on a PR, but just at least one review is requested.

In order to fix the bug the logic of a label selection needs to be updated. Currently the "rejected" label is selected when the status message includes "requested" word, however this word is used in two cases:

  1. when changes are requested (aka current state of the PR is rejected)
  2. when a review is requested from one or many team members
@soulim soulim added the bug Something isn't working label May 11, 2018
@soulim
Copy link
Owner Author

soulim commented May 14, 2018

Despite wrong commit message the bug is fixed in 0b8b07a.

@soulim soulim closed this as completed May 14, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soulim