Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Composer version 2 #62

Closed
wants to merge 1 commit into from
Closed

Add support for Composer version 2 #62

wants to merge 1 commit into from

Conversation

Ayesh
Copy link

@Ayesh Ayesh commented Apr 13, 2020

Composer version 2 has composer-plugin-api version 2. This PR updates the version constraint to ^1 || ^2 so we can support both composer versions.

See What's new in Composer 2 and UPGRADE-2.0 for more changes in API. Empty methods \SLLH\ComposerVersionsCheck\VersionsCheckPlugin::deactivate() and \SLLH\ComposerVersionsCheck\VersionsCheckPlugin::uninstall() are added to make it compatible both versions.

Related discussion in composer/composer#8726.

Composer version 2 has `composer-plugin-api` version 2. This commit updates the version constraint to `^1 || ^2` so we can support both composer versions.

See https://php.watch/articles/composer-2 for more changes in API. Empty methods \SLLH\ComposerVersionsCheck\VersionsCheckPlugin::deactivate() and \SLLH\ComposerVersionsCheck\VersionsCheckPlugin::uninstall() are added to make it compatible both versions.
@soullivaneuh
Copy link
Owner

Thanks @Ayesh! Unfortynatly this is not enough to get Travis running. I have to remove the deprecated styleci bridge that require composer/semver 1.0.

See my WIP at #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants