Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for php-cs-fixer 2 #76

Closed
core23 opened this issue Dec 10, 2016 · 9 comments
Closed

Support for php-cs-fixer 2 #76

core23 opened this issue Dec 10, 2016 · 9 comments

Comments

@core23
Copy link
Contributor

core23 commented Dec 10, 2016

Are there any plans for supporting the new major release?

Using this config produces some warnings

# .styleci.yml
preset: symfony

enabled:
  - binary_operator_spaces
  - combine_consecutive_unsets
  - long_array_syntax
  - linebreak_after_opening_tag
  - no_php4_constructor
  - no_useless_else
  - ordered_class_elements
  - ordered_imports
  - php_unit_construct
  - php_unit_strict

finder:
  exclude:
    - 'Tests/Fixtures'
Fixer "align_double_arrow" does not exist, skipping.
Fixer "align_equals" does not exist, skipping.
Fixer "long_array_syntax" does not exist, skipping.
Fixer "unalign_double_arrow" does not exist, skipping.
Fixer "unalign_equals" does not exist, skipping.
Fixer "concat_without_spaces" does not exist, skipping.
Fixer "no_spaces_inside_offset" does not exist, skipping.
Fixer "no_tab_indentation" does not exist, skipping.
Fixer "phpdoc_type_to_var" does not exist, skipping.
Fixer "print_to_echo" does not exist, skipping.
Fixer "unix_line_endings" does not exist, skipping.

Are you planing to wrap the old name to the new syntax?

@GrahamCampbell
Copy link

TBH, upgrading this package to the new styleci rules and php-cs-fixer will be hard, because there are 26 virtual fixers that don't exist in php-cs-fixer, and the mappings are closed source for now.

@GrahamCampbell
Copy link

I'm toying with the idea of exposing a config file styleci to php-cs-fixer converter on the API.

@GrahamCampbell
Copy link

Ok, I've done that then, similar to the "validate" endpoint, just pass the config file as the "config" parameter. For example: https://api.styleci.io/rules?config=preset:%20psr2. Unlike the validate endpoint, empty config is supported. The design decision with not permitting this on the other endpoint was because it was targeted at validation, so we wanted to be sure people weren't accidently passing nothing. On this endpoint, nothing is treated like the empty config file, you get all the rules generated from the recommended preset with risky enabled.

@core23
Copy link
Contributor Author

core23 commented Dec 11, 2016

Just added a wrapper list for version 2: soullivaneuh/styleci-fixers#14

This list must be implemented after merging.

@soullivaneuh
Copy link
Owner

@core23 styleci-fixers package was updated according to the StyleCI API data.

Anything better?

@core23
Copy link
Contributor Author

core23 commented Jan 24, 2017

Just tried the latest master versions and the error(s) still occur

Btw: There was an other update some days ago: https://styleci.readme.io/docs/change-log

@Nyholm
Copy link

Nyholm commented Aug 28, 2017

What is the status on this issue? @core23 have you given up?

@core23
Copy link
Contributor Author

core23 commented Aug 28, 2017

Not working on this anymore, sorry

@GrahamCampbell
Copy link

Replaced by https://github.com/StyleCI/CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants