Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microphone audio doesn't record along with screencast #1

Closed
soumik-mukherjee opened this issue Apr 13, 2020 · 4 comments · Fixed by #11
Closed

Microphone audio doesn't record along with screencast #1

soumik-mukherjee opened this issue Apr 13, 2020 · 4 comments · Fixed by #11
Assignees
Labels
bug Something isn't working
Milestone

Comments

@soumik-mukherjee
Copy link
Owner

No description provided.

@soumik-mukherjee soumik-mukherjee added the bug Something isn't working label Apr 13, 2020
@soumik-mukherjee soumik-mukherjee added this to the Sprint 1 milestone Apr 13, 2020
@soumik-mukherjee soumik-mukherjee self-assigned this Apr 13, 2020
@soumik-mukherjee soumik-mukherjee added this to To do in Capturio Feature Story Value Stream via automation Apr 13, 2020
@soumik-mukherjee
Copy link
Owner Author

Right now the code to start recording is dealing with a single MediaStream object, i.e. the user's screen (returned by the call to navigator.mediaDevices.getDisplayMedia() ). This stream does not include a track aith the microphone's audio.

@soumik-mukherjee soumik-mukherjee moved this from To do to In progress in Capturio Feature Story Value Stream Apr 13, 2020
@soumik-mukherjee soumik-mukherjee added enhancement New feature or request and removed enhancement New feature or request labels Apr 13, 2020
@soumik-mukherjee
Copy link
Owner Author

Right now the code to start recording is dealing with a single MediaStream object, i.e. the user's screen (returned by the call to navigator.mediaDevices.getDisplayMedia() ). This stream does not include a track aith the microphone's audio.

The microphone (and other system media devices, e.g. camera) stream is available from the same MediaDevice API but through a different method invocation, i.e. MediaDevice.getUserMedia().

So we need a way to combine/mix the two streams together, before MediaRecorder starts recording.

@soumik-mukherjee
Copy link
Owner Author

UX will change:

  1. Need a new RecorderControl to allow user to select sources. This should be a multi-select, with options like,

    • Screen

    • Audio (with available audio input devices listed, only one can be selected)

    • Camera is an ideal candidate but will keep this out of scope for now.

  2. Currently, the RecorderControls component has a Start Capture button, which does both things at the same time

    • Selects the source, i.e. screen media as of now

    • Starts recording the source

  3. The Start Capture button should only start recording, all the user selected streams

  4. The new Select Sources button should be the one to define sources, i.e. take this functionality out of the button state handler

@soumik-mukherjee
Copy link
Owner Author

Deciding to do the UX change as a separate issue, and with its own PR. UX PR has higher priority to merge to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant