-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding loader for DCASE-bioacoustic #112
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 98.52% 98.59% +0.07%
==========================================
Files 24 25 +1
Lines 2096 2205 +109
==========================================
+ Hits 2065 2174 +109
Misses 31 31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nkundiushuti, I am leaving here some comments/suggestions, mostly docs-related! The loader looks good :)
events in jams
should we merge it @genisplaja ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Sorry for the late response. I'm just leaving a tiny comment and looks ready to me :) I think the big docstring of the module could be a bit improved (for instance trying to highlight more the titles/sections so that is more readable), but all the information is there and it's just my personal thought, so feel free to merge otherwise:)
Dataloader for the dataset used in this task https://dcase.community/challenge2022/task-few-shot-bioacoustic-event-detection
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/
, e.g.make_my_dataset_index.py
, which generates an index file.soundata/indexes/
e.g.my_dataset_index.json
.soundata/my_dataset.py
tests/
, e.g.test_my_dataset.py
docs/source/soundata.rst
anddocs/source/quick_reference.rst
tests/test_full_dataset.py
on your dataset.If your dataset is not fully downloadable there are two extra steps you should follow:
pytest -s tests/test_full_dataset.py --local --dataset my_dataset
once on your dataset locally and confirmed it passesPlease-do-not-edit flag
To reduce friction, we will make commits on top of contributor's pull requests by default unless they use the
please-do-not-edit
flag. If you don't want this to happen don't forget to add the flag when you start your pull request.