-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding loader for Warblrb10k #132
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 98.61% 98.64% +0.03%
==========================================
Files 26 27 +1
Lines 2311 2363 +52
==========================================
+ Hits 2279 2331 +52
Misses 32 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tanmayy24, the loader and tests look really good to me :) Thanks for that! Just left minor requested changes mostly on documentation! Let me know if I misunderstood something... thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tanmayy24!! This looks good to me :) I'm approving the PR now
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/
, e.g.make_my_dataset_index.py
, which generates an index file.soundata/indexes/
e.g.my_dataset_index.json
.soundata/my_dataset.py
.tests/
, e.g.test_my_dataset.py
.docs/source/soundata.rst
anddocs/source/quick_reference.rst
.black
,flake8
andmypy
(see Running your tests locally).tests/test_full_dataset.py
on your dataset.