Adding loader for DCASE 2023 Task-2 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 98.69% 98.72% +0.03%
==========================================
Files 28 29 +1
Lines 2447 2515 +68
==========================================
+ Hits 2415 2483 +68
Misses 32 32 |
|
Hi! Is it ready to review? @tanmayy24 |
|
Yes! It's ready for review now! |
tanmayy24
changed the title
genisplaja
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Again, thanks @tanmayy24, looks good to me! Minor changes requested, basically a minor documentation thing and a missing test, let's see if it can be added. The rest looks good to me!
docs/source/soundata.rst
Outdated
| @@ -19,6 +19,13 @@ Dataset Loaders | |||
| .. automodule:: soundata.datasets.marco | |||
| :members: | |||
| :inherited-members: | |||
|
|
|||
| DCASE23-Task2 | |||
| ^^^^^^^^ | |||
soundata/datasets/dcase23_task2.py
Outdated
Comment on lines
380
to
384
| # Check for file existence | ||
| if not os.path.exists(metadata_add_train_path): | ||
| raise FileNotFoundError( | ||
| f"Additional training metadata for {machine} not found. Did you run .download()?" | ||
| ) |
tanmayy24
force-pushed
the
tanmay/dcasetask2
branch
2 times, most recently
from
970ac13
to
b40286f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Please use the following title: "Adding loader for MyDATASET". If your pull request is work in progress, change your title to "[WIP] Adding loader for MyDATASET" to avoid reviews while the loader is not ready.
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/, e.g.make_my_dataset_index.py, which generates an index file.soundata/indexes/e.g.my_dataset_index.json.soundata/my_dataset.py.tests/, e.g.test_my_dataset.py.docs/source/soundata.rstanddocs/source/quick_reference.rst.black,flake8andmypy(see Running your tests locally).tests/test_full_dataset.pyon your dataset.If your dataset is not fully downloadable there are two extra steps you should follow:
pytest -s tests/test_full_dataset.py --local --dataset my_datasetonce on your dataset locally and confirmed it passes.Please-do-not-edit flag
To reduce friction, we will make commits on top of contributor's pull requests by default unless they use the
please-do-not-editflag. If you don't want this to happen don't forget to add the flag when you start your pull request.