Pin @types/bluebird to the last version that worked with TS v3 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruderstein
approved these changes
Feb 16, 2023
pablofmena
approved these changes
Feb 17, 2023
package.json
Outdated
| @@ -41,7 +41,7 @@ | |||
| "sudo-prompt": "^8.2.3", | |||
| "susie": "^3.0.0", | |||
| "ts-node": "^8.10.1", | |||
| "typescript": "^3.8.3", | |||
| "typescript": "^3.9.10", | |||
There was a problem hiding this comment.
would it make sense to use ~ for typescript given we're pinning it as well and it doesn't follow semver strictly?
There was a problem hiding this comment.
yep i think so 👍
lukehorvat
force-pushed
the
fix-ts-compile-bug
branch
from
575c9fb
to
d7aa290
Compare
|
🎉 This PR is included in version 3.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lukehorvat
added a commit
that referenced
this pull request
Feb 17, 2023
The fix from #52 didn't work because I think they configured their `typesVersions` wrong in v3.5.36.
intervene-ci
pushed a commit
that referenced
this pull request
Feb 17, 2023
## [3.1.5](v3.1.4...v3.1.5) (2023-02-17) ### Bug Fixes * Downgrade @types/bluebird to v3.5.34 ([899f03b](899f03b)), closes [#52](#52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Intervene currently supports
3.5.xversions of@types/bluebird. The latest3.5.xversions drop support for TS v3 in favor of TS v4: https://www.npmjs.com/package/@types/bluebird?activeTab=versionsSince Intervene uses TS v3, we need to pin the version of
@types/bluebirdto one that is compatible. Otherwise you will see a lot of TS errors when running a fresh install of Intervene.Pinning is a band-aid fix; obviously in the long term we should upgrade Intervene to TS v4.
How to test
@types/bluebirdto3.5.38(without^) in package.json.make build. It should fail with lots of TS errors.make buildagain. It should succeed with no errors.