Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin @types/bluebird to the last version that worked with TS v3 #52

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Pin @types/bluebird to the last version that worked with TS v3 #52

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4e6f89
fix: Pin @types/bluebird to the last version that worked with TS v3
lukehorvat Feb 16, 2023
d7aa290
fix: Use tilde range for typescript
lukehorvat Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
],
"dependencies": {
"@hapi/hapi": "^20.1.3",
"@types/bluebird": "^3.5.24",
"@types/bluebird": "3.5.36",
"@types/hapi__hapi": "^20.0.8",
"@types/node": "*",
"@types/node-forge": "^0.8.2",
Expand All @@ -41,7 +41,7 @@
"sudo-prompt": "^8.2.3",
"susie": "^3.0.0",
"ts-node": "^8.10.1",
"typescript": "^3.8.3",
"typescript": "^3.9.10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to use ~ for typescript given we're pinning it as well and it doesn't follow semver strictly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep i think so 👍

"why-is-node-running": "^2.0.3",
"yargs": "^12.0.5"
},
Expand Down