Add license information to lhm.gemspec

[christophermanning]

Set the license to New BSD since the current LICENSE file looks like New BSD.

This allows tools like License Finder to look up this project's metadata.

This also fixes the license display at https://rubygems.org/gems/lhm since it currently says 'N/A':

[alikhajeh1]

Out of interest, why not use the MIT license? That seems more popular amongst open source gems.

[arthurnn]

@lgierth ?

[ghost]

I'm fine with whatever license the active contributors choose 👍

[ghost]

I initially misunderstood what the ticket was about. I'm not sure about the reasons for the license choice, that was before my involvement. Unless there is a good reason, it shouldn't be changed.

Nevertheless, if there are good reasons, I'm fine with whatever the active contributors decide.

[arthurnn]

@lgierth Do you know who should I ping about license in here. Probably someone from soundcloud?

[ghost]

Yeah @grobie is probably a good candidate.

[grobie]

I didn't add the license and can't really comment on this. I fear a change of the license would need to be checked with legal first. Unless there are good reasons to change it let's just keep the current one for now?

[arthurnn]

I dont think we should change.. I am just not sure if the current license is "New BSD" or not?!

[grobie]

It's BSD-3 I think: http://opensource.org/licenses/BSD-3-Clause

[christophermanning]

I used the New BSD identifier because that's the main name used in License Finder. But, if it's preferred, the identifier "Modified BSD", "BSD3", "BSD-3", "3-clause BSD", or "BSD-3-Clause" could be used instead with 'BSD 3-Clause' seeming to be the canonical name.

        License.new(
          short_name:  "NewBSD",
          pretty_name: "New BSD",
          other_names: ["Modified BSD", "BSD3", "BSD-3", "3-clause BSD", "BSD-3-Clause"],
          url:         "http://opensource.org/licenses/BSD-3-Clause",
          matcher:     matcher
        )
      end

https://github.com/pivotal/LicenseFinder/blob/96d7d180f1f388f1483ba2eae85abec68a1dcd72/lib/license_finder/license/definitions.rb#L122-L129

[grobie]

Oh, thanks, I missed that. I'm fine with any of them, something including BSD-3 seems to be a bit less ambiguous.

👍 thanks!

[christophermanning]

I've updated the license name to BSD-3-Clause

[arthurnn]

looks good!! thanks!