Ensure Lhm.cleanup removes temporary triggers #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| lhm_tables.each do |table| | ||
| connection.execute("drop table #{table}") | ||
| end | ||
| true | ||
| else | ||
| puts "Existing LHM backup tables: #{lhm_tables.join(", ")}." | ||
| puts "Existing LHM backup tables: #{lhm_tables.join(", ")}." if lhm_tables.any? | ||
| puts "Existing LHM triggers: #{lhm_triggers.join(", ")}." if lhm_triggers.any? | ||
| puts "Run Lhm.cleanup(true) to drop them all." |
There was a problem hiding this comment.
I'd suggest removing all the empty? checks in this method, they increase its complexity, and removing them leaves you with exactly one possible output. Also, in case both tables and triggers are empty, the "Run Lhm.cleanup ..." line is confusing.
There was a problem hiding this comment.
I agree with the confusing parts of it.. especially when a cleanup is not necessary, a true is just given regardless of if its a dry run or not.
How would you feel about more informative output?
examples:
Existing LHM backup tables: 0
Existing LHM triggers: 0
Existing LHM backup tables: lhmn_users.. etc
Existing LHM triggers: lhmt_ins_users.. etc
Run Lhm.cleanup(true) to drop them all.
Or something of the sort?
|
Looks good to me |
|
Oh and please update the readme section about this, at the moment it only mentions leftover tables, not triggers. |
In the event of a failed migration, triggers may not have been dropped properly. To avoid errors, we must drop the lhm triggers before the lhm tables.
edmundsalvacion
added a commit
that referenced
this pull request
Oct 2, 2013
Ensure Lhm.cleanup removes temporary triggers
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event of a failed migration, triggers may not have been dropped
properly. To avoid errors, we must drop the lhm triggers before the lhm
tables.