Fixes for local development and instructions for getting set up #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Looks good, would highly prefer squashing these commits together though. |
|
I am not sure about this change, IMO it just adds an extra step. and having the |
|
The Gemfile instructions, I created a separate PR, #56 updating the readme under spec/readme . Thoughts @mortice @edmundsalvacion |
Add development setup instructions updating README for proper Gemfile use Default password to nil if no config provided Remove Gemfile-specified dev dependencies from gemspec
arthurnn
added a commit
that referenced
this pull request
Apr 2, 2014
Fixes for local development and instructions for getting set up
|
Thanks for the PR |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.