Make the primary key to use for the migration configurable #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @ags, hopefully this gets merged soon. |
ags
changed the title
ags
force-pushed
the
configurable_primary_key
branch
from
fcac683
to
b84952d
Compare
|
@ags thanks for the PR, do you mind rebasing this against latest master and add a changelog entry for it? |
ags
force-pushed
the
configurable_primary_key
branch
3 times, most recently
from
23851b8
to
bcae636
Compare
ags
added a commit
to ags/lhm
that referenced
this pull request
Mar 25, 2015
ags
force-pushed
the
configurable_primary_key
branch
from
bcae636
to
91a6468
Compare
ags
added a commit
to ags/lhm
that referenced
this pull request
Mar 25, 2015
ags
force-pushed
the
configurable_primary_key
branch
from
91a6468
to
d373e71
Compare
ags
added a commit
to ags/lhm
that referenced
this pull request
Mar 25, 2015
ags
force-pushed
the
configurable_primary_key
branch
4 times, most recently
from
633ec01
to
be8004d
Compare
ags
added a commit
to ags/lhm
that referenced
this pull request
Mar 25, 2015
ags
force-pushed
the
configurable_primary_key
branch
from
be8004d
to
4b235e4
Compare
ags
added a commit
to ags/lhm
that referenced
this pull request
Mar 25, 2015
ags
force-pushed
the
configurable_primary_key
branch
from
4b235e4
to
288a4a5
Compare
ags
added a commit
to ags/lhm
that referenced
this pull request
Mar 25, 2015
ags
force-pushed
the
configurable_primary_key
branch
from
288a4a5
to
efb5e37
Compare
ags
added a commit
to ags/lhm
that referenced
this pull request
Mar 25, 2015
Instead of relying on a table to have a primary key, we now accept the order_column option and put that everywhere. This kind of uncomfortable state about the migration now needs to be given to everyone and I think an appropriate place is the migration, since most objects in the system have access to it and they all need to agree on the value. This required passing the options down a couple more objects for the Migrator creating the Migration to have access, but I think thats acceptable for this increase in functionality.
ags
force-pushed
the
configurable_primary_key
branch
from
efb5e37
to
bc819f2
Compare
|
Sorry for the bump, but any idea if/when this will be merged? Thanks! |
| @@ -188,7 +189,11 @@ def validate | |||
| end | |||
|
|
|||
| unless @origin.satisfies_id_autoincrement_requirement? | |||
There was a problem hiding this comment.
There's no way for this to not error out when an order_column is specified.
@origin.satisfies_id_autoincrement_requirement? checks the id column, even if an order_column is set. Once that check fails, an error is set no matter what. The code should probably look more like:
if @options[:order_column]
if !@origin.can_use_order_column?(@options[:order_column])
error("origin does not satisfy primary key requirements")
end
else
if !@origin.satisfies_id_autoincrement_requirement?
error("origin does not satisfy primary key requirements")
end
end
Sorry for the comment, not sure what the best way to submit changes to a PR is. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a squashed and rebased version of #49, since @airhorns seems unreachable.
There were a few conflicts, which I've resolved. It'd be great if we can get this looked at again!
#49