Avoid hardcoded window.location.protocol

[jtomaszewski]

Currently in the SDK protocol is hardcoded (a lot of window.location.protocol references). This makes the SDK unusable in Apache Cordova - as apps there have a file:// protocol.

A simple fix replacing all window.location.protocol with f.e. SC.options.protocol would be sufficient.

[gillesdemey]

Currently experiencing the same issue using Electron (or Node WebKit for that matter).

[angusfretwell]

👍

[chrisrickard]

Same issue... quite a show stopper.

Any word on this?

👍👍👍

[gillesdemey]

I've been using my own simple module for now, but I'm happy to take a look at this and send a PR if they're being looked at (I see a few PR's open from years ago).

[bluedaniel]

Yeah seeing this as well with Electron

[angusfretwell]

Here's a patched copy of the minified API which I bundled as a node module: https://github.com/angusfretwell/soundcloud-cordova-sdk

Suppose I should remove Cordova from the name of the package since this problem isn't really specific to Cordova 😅