Improve performance (maybe) #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- scale the number of audio-decoding workers from 4 previously to the number of logical cores presumably available as reported by the browser via navigator.hardwareConcurrency. See https://twitter.com/tpillard/status/1297562478822543360 - do not spawn more audio-decoding workers than number of chunks to decode. - when reconstructing the final AudioBuffer, use AudioBuffer.prototype.copyToChannel() instead of combination of AudioBuffer.prototype.getChannelData() + TypedArray.prototype.set() + Add basic ./benchmark folder + Add third optional `options: { concurrency }` argument: - `getFileAudioBuffer(file, audioCtx, options = {})` - `concurrency` option must be a number, a falsy value will result in the "auto" mode being used.
ziir
force-pushed
the
maybe-improve-performance
branch
from
8e7088c
to
21da806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scale the number of audio-decoding workers from 4 previously to the number
of logical cores presumably available as reported by the
browser via
navigator.hardwareConcurrency.do not spawn more audio-decoding workers than number of chunks to
decode.
when reconstructing the final
AudioBuffer, useAudioBuffer.prototype.copyToChannel()instead of combination ofAudioBuffer.prototype.getChannelData()+TypedArray.prototype.set()options: { concurrency }argument:getFileAudioBuffer(file, audioCtx, options = {})concurrencyoption must be a number, a falsy value will result in the "auto" mode being used.